Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-inspector to fix #1831 #1888

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Sep 24, 2017

Fixed #1831

@codecov
Copy link

codecov bot commented Sep 24, 2017

Codecov Report

Merging #1888 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1888   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5740     5740           
  Branches      696      686   -10     
=======================================
  Hits         1224     1224           
- Misses       3961     3998   +37     
+ Partials      555      518   -37
Impacted Files Coverage Δ
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.43% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08a016...7163615. Read the comment docs.

@danielduan
Copy link
Member

let's get this one merged and published too. @shilman this is a bug that should make it into the next patch release as well.

@ndelangen ndelangen merged commit 5408c76 into master Sep 25, 2017
@ndelangen ndelangen deleted the update-react-inspector branch September 25, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants