Build: Use ts-up to build addon-links #18908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciana-mendonca
commented
Aug 9, 2022
Comment on lines
+40
to
+43
| "./react": { | ||
| "require": "./dist/react/index.js", | ||
| "import": "./dist/react/index.mjs", | ||
| "types": "./dist/react.d.ts" |
There was a problem hiding this comment.
While testing in examples/official-storybook, I noticed that there are imports from @addon-links/react, so I needed to add this endpoint here.
Please, let me know if there's a better approach!
There was a problem hiding this comment.
I think we'll want to deprecate this at some point in the future, but that will be a separate issue/PR, so great work!
luciana-mendonca
force-pushed
the
build/addon-links-tsup
branch
from
f72789a to
46f21be
Compare
|
Muito obrigado @luciana-mendonca !! |
ndelangen
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18732
What I did
Migrated
addon-linksto use thets-upbundler.How to test
If your answer is yes to any of these, please make sure to include it in your PR.