Synced changes from new-docs to CONTRIBUTING.md #1906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 1624-viewport-addon
Fix incorrect command
A CLI for running specific tests suites, like bootstrap CLI
Release/3.3
….0.0 Add dependencies.yml for dependencies.io
Update dependencies.yml
Remove greenkeeper & travis ADD BCH & Slack & opencollective
addon-links: add `LinkTo` component, and `hrefTo` function
# Conflicts: # CHANGELOG.md # CONTRIBUTING.md # addons/actions/package.json # addons/centered/package.json # addons/comments/package.json # addons/events/package.json # addons/graphql/package.json # addons/info/package.json # addons/knobs/package.json # addons/links/package.json # addons/notes/package.json # addons/options/package.json # addons/storyshots/package.json # app/react-native/package.json # app/react/package.json # app/vue/package.json # lerna.json # lib/addons/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/channels/package.json # lib/cli/package.json # lib/codemod/package.json # lib/components/package.json # lib/ui/package.json
Fix root level rendering
CLI: Use actions in sample stories for vue + fix them in SFC_VUE template
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
=======================================
Coverage 21.31% 21.31%
=======================================
Files 257 257
Lines 5737 5737
Branches 691 691
=======================================
Hits 1223 1223
+ Misses 3989 3974 -15
- Partials 525 540 +15
Continue to review full report at Codecov.
|
Hypnosphi
requested changes
Sep 28, 2017
CONTRIBUTING.md
Outdated
| This will watch files and transpile in watch mode. | ||
| - node | ||
| - yarn | ||
| - @storybook/cli |
There was a problem hiding this comment.
@ storybook / cli or the whole prerequisites section?
There was a problem hiding this comment.
The cli package. You either use example app, or your own, which already has storybook
CONTRIBUTING.md
Outdated
| > It's pretty important to create a very simple sample project like above. | ||
| > Otherwise some of the functionality won't work because of linking. | ||
| 1. `yarn bootstrap` | ||
| 2. At the prompt: `a`, `enter`, `y`, `enter` ( `a` selects all (fully bootstrap) and `y` is to confirm) |
There was a problem hiding this comment.
There is a shortcut for it: yarn bootstrap --all
CONTRIBUTING.md
Outdated
| cd my-demo-app | ||
| getstorybook | ||
| ``` | ||
| This method is slow, and if you are reading this tutorial you probably don't want to do it |
There was a problem hiding this comment.
"if you are reading this tutorial" doesn't apply here
CONTRIBUTING.md
Outdated
| ``` | ||
| ### Working with the kitchen sink apps | ||
|
|
||
| Within the examples folder of the Storybook repo, you will find kitchen sink examples of storybook implementations for the various platforms that storybook supports. |
There was a problem hiding this comment.
Please put examples in backticks
|
Please rebase it on |
# Conflicts: # CHANGELOG.md # addons/actions/package.json # addons/comments/package.json # addons/info/package.json # addons/storyshots/package.json # app/react-native/package.json # app/react/package.json # app/vue/package.json # examples/cra-kitchen-sink/src/stories/index.js # lerna.json # lib/ui/package.json
dangreenisrael
force-pushed
the
sync-CONTRIBUTING-on-master-with-new-docs
branch
from
0fcb782
to
ce3b0cb
Compare
|
New PR (to new-docs) #1911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Reference: #1886
What I did
Synced CONTRIBUTING.md with updated in
new-docsbranchHow to test
N/A: Just added docs