Fix path to checkActionsLoaded #19334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I got an error in a different PR:
https://app.circleci.com/pipelines/github/storybookjs/storybook/29618/workflows/0931a8cf-b0da-4cbd-8a03-9bad0fdf9174/jobs/418314?invite=true#step-105-471
What I did
I noticed that in the transition to tsup for addon-interactions, a few things seemed to be missed. This PR updates the link from
preset.jsto the correct build location, and also adds the target (checkActionsLoaded) to the list of entry points.The part I'm not sure about is adding
platform: node, since different parts of the addon runs both in node and in the browser. But,checkActionsLoadeduses thepathnode builtin, so it needed the flag to build correctly.How to test
If your answer is yes to any of these, please make sure to include it in your PR.