Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: remove npx usage from storybook scripts #19366

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Oct 5, 2022

Issue: https://github.com/yarnpkg/berry/actions/runs/3191237001/jobs/5207299422

#17898 updated the scripts added to the project to use npx.

What I did

Removed npx from the scripts added to the project package.json during

yarn dlx -p @storybook/cli@next sb init --yes

How to test

The e2e tests should have covered this but seems it was removed in #19303.

@yannbf yannbf changed the title fix(cli): don't use npx in scripts CLI: remove npx usage from storybook scripts Oct 10, 2022
@yannbf yannbf self-assigned this Oct 10, 2022
@yannbf
Copy link
Member

yannbf commented Oct 11, 2022

This is great, thank you so much for your contribution @merceyz <3

@yannbf yannbf merged commit c49de7d into storybookjs:next Oct 11, 2022
@merceyz merceyz deleted the merceyz/fix/no-npx-in-scripts branch October 11, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants