-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vite-plugin-svelte-kit when detected #19522
Conversation
// recursively remove all plugins with the given names | ||
export const withoutVitePlugins = ( | ||
plugins: PluginOption[] = [], | ||
namesToRemove: string[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've unintentionally helped me add another feature which I've had in mind, which is allowing users to remove plugins from their vite config by providing a list of names, similar to what Histoire allows: https://histoire.dev/guide/config.html#ignoring-plugins. Having this function will come in handy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha great. I just thought that I'd written it 3 times now that it probably deserves it's own utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JReinhold FWIW I think this is a maintenance
PR since it touches user-facing code in a significant way. build
means it's completely internal to our build system.
@shilman We really need a written guide on those labels soon. 😬 |
Can someone explain how it should work now ? Previously I've had workaround |
None of that should be necessary anymore as Storybook automatically handles that, so hopefully you should be able to delete that. If you're still experiencing issues with your specific setup I might be easier to reach out on Discord. I'm JReinhold#4884 |
Issue: #19280
What I did
vite-plugin-svelte-kit
when detected as per discussions in [7.0] Incompatible with sveltekit #19280How to test
svelte-kit/skeleton-js
sandbox