-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final few deprecations removal in a batch #19553
Conversation
@shilman Do you think you can help me understand why https://app.circleci.com/pipelines/github/storybookjs/storybook/30614/workflows/4a03924c-4716-4d9e-ac10-c499ba5fdae8/jobs/429471 is failing? Seems the background color isn't applied anymore, but I can't seem to find the reason why. |
@tmeasday you marked adding unknown globals as deprecated, but it looks like removing that actually breaks addon-backgrounds? |
Well yeah, I guess backgrounds should export a |
That fixed it @tmeasday |
@shilman mentioned that he wanted to discuss this deprecation further. He said that silently ignoring new incoming properties was not a good idea. I tend to agree. |
I'll add a bit of code that throws an error when a property is filtered out |
@tmeasday can you chime in on why we want to force addons to declare their |
@shilman, according to the original commit:
I don't really have any recollection of it, to be honest. I don't feel strongly about it. |
@tmeasday thanks, just checking. i think we should do it FWIW. |
removal of the last few deprecations for 7.0