Update react-native from 0.43.4 to 0.49.3 in app/react-native

[dependencies]

react-native has been updated to 0.49.1 in app/react-native by dependencies.io

0.49.1

No content found.

0.49.0

No content found.

[Hypnosphi]

Please someone check that RN stuff keeps working

[codecov]

Codecov Report

Merging #1971 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1971   +/-   ##
======================================
  Coverage    21.4%   21.4%           
======================================
  Files         263     263           
  Lines        5812    5812           
  Branches      694     690    -4     
======================================
  Hits         1244    1244           
- Misses       4041    4063   +22     
+ Partials      527     505   -22

Impacted Files	Coverage Δ
app/vue/src/server/utils.js	0% <0%> (-53.58%)	⬇️
.../src/manager/containers/CommentsPanel/dataStore.js	34.97% <0%> (ø)	⬆️
app/react-native/src/bin/storybook-start.js	0% <0%> (ø)	⬆️
...codemod/src/transforms/update-organisation-name.js	40.62% <0%> (ø)	⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js	6.25% <0%> (ø)	⬆️
lib/ui/src/libs/key_events.js	23.25% <0%> (ø)	⬆️
...ponents/left_panel/stories_tree/tree_decorators.js	33.33% <0%> (ø)	⬆️
...react-native/src/manager/components/PreviewHelp.js	0% <0%> (ø)	⬆️
lib/ui/src/modules/api/configs/init_api.js	40.47% <0%> (ø)	⬆️
lib/components/src/navigation/menu_link.js	0% <0%> (ø)	⬆️
... and 24 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad3ea3...74ec0f7. Read the comment docs.

[danielduan]

have you tested this by any chance? I just ran this branch and did the whole bootstrap thing.

Our vanilla project for iOS needs some updating. it's throwing a lot of warnings and doesn't build anymore. I'm on XCode 8.3.3 but I'm pretty sure the latest 9.0 will fail as well.

Our CRNA app has a bundler error undefined is not an object (evaluating 'nativeVersion.major)

I'm not sure that this is a change caused by updating react-native, but I think something's wrong.

[Hypnosphi]

have you tested this by any chance?

Not really, that's why I asked for help. Do you have any idea how to catch such errors on CI btw?

[danielduan]

No idea. This doesn't show up until I launch the iOS simulator or attempt to compile it in XCode which we can't do in CI.

Let's hold off on merging this for now.

[danielduan]

I'm going to upgrade our expo dependencies for CRNA, they're mismatched right now:
https://github.com/react-community/create-react-native-app/blob/master/VERSIONS.md

[danielduan]

Since these are dev dependency updates, I feel pretty confident merging this one in since the test kitchens do work.

As part of the overall 0.49 react-native upgrade, I think there might be some other edge cases out there in terms of the CLI that we might to fix.