-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use execa 6.x in scripts
#19759
Merged
tmeasday
merged 12 commits into
next
from
tom/sb-880-update-execa-and-try-to-fix-waiting
Nov 21, 2022
Merged
Use execa 6.x in scripts
#19759
tmeasday
merged 12 commits into
next
from
tom/sb-880-update-execa-and-try-to-fix-waiting
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use an obtuse method to import it as it is ESM only and `ts-node` doesn't play well with that. See TypeStrong/ts-node#1290
ndelangen
approved these changes
Nov 8, 2022
All looks good to me, except for this failure:
|
…ca-and-try-to-fix-waiting
…ca-and-try-to-fix-waiting
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use an obtuse method to import it as it is ESM only and
ts-node
doesn't play well with that.See TypeStrong/ts-node#1290
How to test
I'm not sure how to test all the other scripts, but if the CI passes, the
task
runner is working