Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vitejs and esbuild #20199

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Conversation

codeisforme
Copy link

@codeisforme codeisforme commented Dec 12, 2022

Issue: #20190

What I did

This upgrades the dependencies so that a fresh pull will compile and start. If you have an existing build please clear out all files NOT checked in to the code base (git ignored, including node_modules)

How to test

  • Test yarn start and yarn ci-tests

If your answer is yes to any of these, please make sure to include it in your PR.

@codeisforme
Copy link
Author

@MichaelArestad looks like react-mdx.stories.mdx is the deal-breaker, same in other PR's, any thoughts?

@JReinhold
Copy link
Contributor

looks like react-mdx.stories.mdx is the deal-breaker, same in other PR's, any thoughts?

I've addressed that in #20210

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you upgrade @sveltejs/vite-plugin-svelte in svelte-vite and @vitejs/plugin-vue in vue3-vite as well?

@IanVS
Copy link
Member

IanVS commented Dec 12, 2022

We discussed in the triage meeting that it would be best to make this PR only upgrade ESBuild. I'll work on a separate PR to update vite and the associated plugins.

@codeisforme
Copy link
Author

We discussed in the triage meeting that it would be best to make this PR only upgrade ESBuild. I'll work on a separate PR to update vite and the associated plugins.

@IanVS I reverted the changes to @vitejs/plugin-react. The build won't pass without it, but esbuild is still upgraded to 0.16.4

@codeisforme codeisforme requested review from JReinhold and removed request for ndelangen December 12, 2022 23:56
@IanVS
Copy link
Member

IanVS commented Dec 13, 2022

The failing tests are in svelte. I wonder if they'll be fixed by #20212, or if something else is going on.

@JReinhold
Copy link
Contributor

Pulling in next should turn CI green now.

@ndelangen ndelangen merged commit a735bb9 into storybookjs:next Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants