-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade vitejs and esbuild #20199
upgrade vitejs and esbuild #20199
Conversation
@MichaelArestad looks like |
I've addressed that in #20210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you upgrade @sveltejs/vite-plugin-svelte
in svelte-vite
and @vitejs/plugin-vue
in vue3-vite
as well?
We discussed in the triage meeting that it would be best to make this PR only upgrade ESBuild. I'll work on a separate PR to update vite and the associated plugins. |
@IanVS I reverted the changes to |
The failing tests are in svelte. I wonder if they'll be fixed by #20212, or if something else is going on. |
Pulling in |
…ade-deps Pull latest next
Issue: #20190
What I did
This upgrades the dependencies so that a fresh pull will compile and start. If you have an existing build please clear out all files NOT checked in to the code base (git ignored, including node_modules)
How to test
If your answer is yes to any of these, please make sure to include it in your PR.