Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Undo AST main.js check in validateConfigFile #20952

Merged
merged 1 commit into from
Feb 6, 2023
+0 −11
Merged

Core: Undo AST main.js check in validateConfigFile #20952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion code/lib/core-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
},
"dependencies": {
"@babel/core": "^7.20.2",
"@storybook/csf-tools": "7.0.0-beta.43",
"@storybook/node-logger": "7.0.0-beta.43",
"@storybook/types": "7.0.0-beta.43",
"@types/babel__core": "^7.1.20",
Expand Down
9 changes: 0 additions & 9 deletions code/lib/core-common/src/utils/validate-configuration-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { dedent } from 'ts-dedent';
import { promise as glob } from 'glob-promise';
import path from 'path';
import slash from 'slash';
import { readConfig } from '@storybook/csf-tools';
import { once } from '@storybook/node-logger';

import { boost } from './interpret-files';
Expand All @@ -25,13 +24,5 @@ export async function validateConfigurationFiles(configDir: string) {
No configuration files have been found in your configDir (${path.resolve(configDir)}).
Storybook needs "main.js" file, please add it.
`);
} else {
const main = await readConfig(mainConfigPath);
if (!main.hasDefaultExport) {
once.warn(dedent`
Your main.js is not using a default export, which is the recommended format. Please update it.
For more info: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#esm-format-in-mainjs
`);
}
}
}
1 change: 0 additions & 1 deletion code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6068,7 +6068,6 @@ __metadata:
resolution: "@storybook/core-common@workspace:lib/core-common"
dependencies:
"@babel/core": ^7.20.2
"@storybook/csf-tools": 7.0.0-beta.43
"@storybook/node-logger": 7.0.0-beta.43
"@storybook/types": 7.0.0-beta.43
"@types/babel__core": ^7.1.20
Expand Down