Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Add env type to BuilderOptions #21173

Merged
merged 4 commits into from
Feb 27, 2023
Merged

TypeScript: Add env type to BuilderOptions #21173

merged 4 commits into from
Feb 27, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Feb 20, 2023

Closes #

Ref: #17862 (comment)

What I did

I could see that both builders use options.presets.apply<Record<string, string>>('env'), but as reported, we did not include env in our TS types. This adds it to BuilderOptions.

How to test

Reference env in the config of a TypeScript sandbox.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@IanVS
Copy link
Member Author

IanVS commented Feb 21, 2023

I'm not familiar with the Angular setup, and not sure the best way to fix the type error there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants