Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix Playwright to v1.30.0 #21194

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Build: Fix Playwright to v1.30.0 #21194

merged 2 commits into from
Feb 22, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Feb 21, 2023

What I did

This PR fixes the sandbox resolutions for @playwright/test to v1.30.0, as CI is currently failing because the Playwright image is doesn't match the installed version.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold self-assigned this Feb 21, 2023
@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Feb 21, 2023
@socket-security
Copy link

socket-security bot commented Feb 21, 2023

Socket Security Pull Request Report

👍 No dependency changes detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues

Powered by socket.dev

@JReinhold JReinhold changed the title Build: Upgrade Playwright to v1.31.0 Build: Fix Playwright to v1.30.0 Feb 22, 2023
@JReinhold JReinhold requested a review from yannbf February 22, 2023 08:43
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to upgrade playwright to 1.31.0 if you'd like. Seems like it uses Node 18 now, and bumps one version of browsers: https://github.com/microsoft/playwright/releases/tag/v1.31.0

@JReinhold JReinhold merged commit 8998bde into next Feb 22, 2023
@JReinhold JReinhold deleted the upgrade-playwright branch February 22, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants