Avoid logging an object on compilation errors #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain configurations Storybook might log the whole Webpack build object when warnings or errors are thrown. This was caused by a `logger.error` call inside the `index.js` catch. This fixes by logging the error only when it's an instance of an error.
Codecov Report
@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
- Coverage 21.42% 21.42% -0.01%
==========================================
Files 263 263
Lines 5805 5806 +1
Branches 703 703
==========================================
Hits 1244 1244
+ Misses 4012 4003 -9
- Partials 549 559 +10
Continue to review full report at Codecov.
|
ndelangen
requested changes
Oct 25, 2017
There was a problem hiding this comment.
Hi @derekstavis, Thank you for this!
Could you apply the same fix for app/vue and app/react-native?
|
@derekstavis would you like help putting this into the other 2 apps? |
|
Yes, will do sometime today! Thanks! |
|
@derekstavis we're looking to get a new release out sometime today. would love to have this in. |
|
Opened #2199 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In certain configurations Storybook might log the whole Webpack
build object when warnings or errors are thrown. This was caused
by a
logger.errorcall inside theindex.jscatch.What I did
This fixes by logging the error only when it's an instance of an error.
How to test
This branch was tested on https://github.com/pagarme/pilot. Before
this changes, if an error happens while compiling (e.g. imported file not
found) a big object is logged:
Resolves
#1889.
Is this testable with jest or storyshots?
Nope.
Does this need a new example in the kitchen sink apps?
Nope.
Does this need an update to the documentation?
Nope.
If your answer is yes to any of these, please make sure to include it in your PR.