UI: Remove css zoom #21303
Merged
UI: Remove css zoom #21303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi @Luk-z! Could you share an example for us to look into this in more detail, please? |
|
Hi @integrayshaun , sorry for late response... Here the example. As You can see I wrapped the 2 story inside a div, simulating Canvas story container using transform scale. In the Docs page using scale the result is more coherent with a canvas/container behavior. |
|
Hi @Luk-z, Thank you for your contribution! It seems, that you have some Typescript related issues on your branch: https://github.com/storybookjs/storybook/actions/runs/4718187330/jobs/8367516000?pr=21303#step:4:367 |
|
@valentinpalkovic fixed! |
valentinpalkovic
changed the title
valentinpalkovic
approved these changes
Jul 10, 2023
14 tasks
This was referenced Jul 25, 2023
|
Causing unexpected behaviors in the following Github Issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21302
What I did
Remove the support of css zoom because it's a non-standard feature and should not be used as i described here.
How to test
Just create a story in a docs page with a fixed div (with top, left, bottom and right 0px).
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]