Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix info not importing docgen descriptions #2133

Merged
merged 5 commits into from
Oct 31, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Oct 26, 2017

Issue:

Addon-Info no longer displays component description comment from react-docgen. Think it might have been broken since we implemented hierarchy.

screen shot 2017-10-26 at 6 44 41 pm

What I did

fixed it

How to test

Is this testable with jest or storyshots?
yes

Does this need a new example in the kitchen sink apps?
no, existing example should already work

Does this need an update to the documentation?
yes

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #2133 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2133   +/-   ##
=======================================
  Coverage   21.42%   21.42%           
=======================================
  Files         263      263           
  Lines        5805     5805           
  Branches      700      686   -14     
=======================================
  Hits         1244     1244           
- Misses       4003     4048   +45     
+ Partials      558      513   -45
Impacted Files Coverage Δ
addons/info/src/components/Story.js 76.19% <0%> (ø) ⬆️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.09% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa3945...faef7d8. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from usulpro October 27, 2017 23:45
@danielduan danielduan added the bug label Oct 29, 2017
@Hypnosphi Hypnosphi merged commit 64c29d7 into master Oct 31, 2017
@Hypnosphi Hypnosphi deleted the dd/fix-info-story-description branch October 31, 2017 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants