-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add remount story shortcut #21401
Conversation
Hello @Roel-t thank you for this PR, just a heads-up: it might take a little while for the core team to look at this, because the current focus is getting 7.0 shipped. We won't merge features at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work, @Roel-t !!! I love this 😍 thank you so so much!!
@yannbf Thank you!! So how do I go on merging the PR? I see danger JS is failing and giving |
@Roel-t I merged in next, let's see if CI approves now. |
UI: Add remount story shortcut
@ndelangen please don't label feature requests with the |
Closes #18669
What I did
alt + R
How to test
Click
alt + R
and verify remount button animates and works.Set new key bind to remount shortcut.
Reset key binds and verify it goes back to default.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]