-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewport: Fix the defaultOrientation
config option
#21536
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
Fix the
Viewport: Fix the Mar 13, 2023
defaultOrientation
config option of the viewport addon.defaultOrientation
config option
ndelangen
approved these changes
Mar 14, 2023
@shilman I think this is actually a good bugfix to merge into 7.0. WDYT? |
@jpzwarte did you intend to delete the branch (which auto-closes PRs)? |
NO :( |
I removed my local fork, which caused this PR to be closed :( Was not my intention. |
@ndelangen Can we merge this one? |
I can't update this @jpzwarte
|
jpzwarte
added a commit
that referenced
this pull request
Apr 6, 2023
@ndelangen see the new PR: #21962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So #21048 was actually broken. This fixes that (tested this time!).