UI: Show current search shortcut in search box sidebar #21619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
gitstart
force-pushed
the
ui/show-current-search-shortcut
branch
from
22419a5 to
cf70e64
Compare
Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
…thub.com/gitstart/storybook into ui/show-current-search-shortcut
kylegach
added
the
patch:yes
5 tasks
yannbf
reviewed
May 9, 2023
| @@ -126,6 +126,7 @@ const FocusKey = styled.code(({ theme }) => ({ | |||
| borderRadius: 3, | |||
| userSelect: 'none', | |||
| pointerEvents: 'none', | |||
| fontFamily: 'inherit', | |||
There was a problem hiding this comment.
This is super interesting! I think you spotted a problem that has been there for quite some time cc @MichaelArestad
The font-family for code elements is ui-monospace, while the rest of Storybook uses Nunito sans. I think it'd be better to handle this elsewhere, so we can also fix the issues in the setting tooltip. For instance, it looks like this now:
with the font fixed, it will look like this:
There was a problem hiding this comment.
Howdy! Nice catch! Can you undo this change? I will fix this typeface in a followup PR. Thank you!
yannbf
approved these changes
May 9, 2023
5 tasks
…thub.com/gitstart/storybook into ui/show-current-search-shortcut
Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 12, 2023
UI: Show current search shortcut in search box sidebar
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #21325
What I did
/on search field by the shortcut keyHow to test
/This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.