Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-common): fix missing env at StorybookConfig #21732

Merged
merged 5 commits into from
Mar 24, 2023
Merged

fix(core-common): fix missing env at StorybookConfig #21732

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed68bc9
fix(core-common): fix missing env at StorybookConfig
zigang93 Mar 22, 2023
f2b88c1
refactor(core-common): remove env from BuilderOptions
zigang93 Mar 22, 2023
a60ecd8
Update code/lib/types/src/modules/core-common.ts
ndelangen Mar 24, 2023
d982529
cleanup
ndelangen Mar 24, 2023
0d68046
Merge branch 'next' into next-zigang
ndelangen Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions code/lib/types/src/modules/core-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ export interface BuilderOptions {
cache?: FileSystemCache;
configDir: string;
docsMode?: boolean;
env?: (envs: Record<string, string>) => Record<string, string>;
features?: StorybookConfig['features'];
versionCheck?: VersionCheck;
releaseNotesData?: ReleaseNotesData;
Expand Down Expand Up @@ -356,7 +355,10 @@ export interface StorybookConfig {
config: TransformOptions,
options: Options
) => TransformOptions | Promise<TransformOptions>;

/**
* Modify or return env config.
*/
env?: (envs: Record<string, string>) => Record<string, string>;
ndelangen marked this conversation as resolved.
Show resolved Hide resolved
/**
* Modify or return babel config.
*/
Expand Down