Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(attempt 2) Build: Add e2e-tests-dev task #21763

Closed
wants to merge 1 commit into from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 24, 2023

Closes #21546

What I did

We have been running e2e tests against built Storybooks, but not against Storybooks in dev mode.
This PR solves that!

How to test

Run a e2e-tests-dev for template, e.g. yarn task --task e2e-tests-dev --start-from auto --template react-vite/default-ts

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Mar 24, 2023
@yannbf yannbf closed this Mar 24, 2023
@stof stof deleted the build/add-e2e-for-dev-mode branch August 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant