Angular: Fix components disappearing on docs page on property change #21944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
patch:yes
…application references, and add support for resetting applications for a specific DOM node in resetApplications().
valentinpalkovic
force-pushed
the
valentin/fix-angular-disappearing-stories-on-docs-page
branch
from
6d5893b
to
9204e55
Compare
shilman
changed the title
sheriffMoose
approved these changes
Apr 5, 2023
valentinpalkovic
deleted the
valentin/fix-angular-disappearing-stories-on-docs-page
branch
This was referenced Apr 5, 2023
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Apr 6, 2023
…pearing-stories-on-docs-page Angular: Fix components disappearing on docs page on property change
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21894
What I did
Refactor AbstractRenderer to use a Map instead of a Set for tracking application references, and add support for resetting applications for a specific DOM node in resetApplications().
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]