Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Mark qwik as using addon-interactions #22000

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

literalpie
Copy link
Contributor

What I did

Add Qwik to the list of frameworks that supports interactive stories.

See this PR in the storybook-framework-qwik project where I update the templates to match other frameworks. If I release that before this PR, the storybook addon-interactions dependency will be missing for people who use npm init with Qwik.

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@literalpie literalpie changed the title feat: mark qwik as having interactive stories feat: mark qwik as using addon-interactions Apr 8, 2023
@kylegach kylegach added maintenance User-facing maintenance tasks cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 10, 2023
@shilman shilman changed the title feat: mark qwik as using addon-interactions CLI: Mark qwik as using addon-interactions Apr 10, 2023
@shilman
Copy link
Member

shilman commented Apr 10, 2023

@literalpie let me know when you merge/release that PR and I'll merge/release this one?

@literalpie
Copy link
Contributor Author

literalpie commented Apr 11, 2023

I think merging this one first would be best. The Qwik-framework PR reference the package added by this PR, so merging that one first will cause build failures for people until this one merged. I don't think the reverse is true.

@literalpie
Copy link
Contributor Author

@shilman are you okay with merging this one first? I'd also be willing to release my package's update first too, it's just not my first choice. (either way shouldn't be a big deal as long as we're quick about it)

@shilman
Copy link
Member

shilman commented Apr 16, 2023

@literalpie sorry I missed your previous comment. Fine with me. Can you update your PR from next so that CI passes? Then I can merge this.

@literalpie literalpie force-pushed the qwik-interactive-stories branch from bb83936 to 5e8acd0 Compare April 16, 2023 12:11
@shilman shilman merged commit 7100ab4 into storybookjs:next Apr 16, 2023
@shilman
Copy link
Member

shilman commented Apr 16, 2023

@literalpie Done! Do you need me to release?

@literalpie
Copy link
Contributor Author

Sweet! Yes, if you can that would be good. I can start a release too

@shilman
Copy link
Member

shilman commented Apr 17, 2023

@literalpie here you go. i'll release it on latest in the next patch release https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.5

Confusingly, this is on the future npm tag

@literalpie
Copy link
Contributor Author

Great! Thank you

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 18, 2023
shilman added a commit that referenced this pull request Apr 18, 2023
CLI: Mark qwik as using addon-interactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants