Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: (UI) Updates sidebar composition links #22033

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

jonniebigodes
Copy link
Contributor

With this pull request, the URLs provided for the composition documentation in our UI were updated to point at the right place, as they were only pointing users to the website instead of the actual place where the documentation lives.

Closes #21507

What was done:

  • Update both links featured in the info dropdown to point at the right location in our documentation

@ndelangen, when you have a moment, can you take a look and let me know of any feedback you may have so that we can continue to work on this or merge it? Thanks in advance.

@jonniebigodes jonniebigodes added bug ui documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 11, 2023
@jonniebigodes jonniebigodes requested a review from ndelangen April 11, 2023 18:37
@jonniebigodes jonniebigodes changed the title Updates Sidebar composition links Chore: (UI) Updates sidebar composition links Apr 11, 2023
@jonniebigodes jonniebigodes removed the bug label Apr 11, 2023
@jonniebigodes
Copy link
Contributor Author

Thanks for reviewing this pull request @ndelangen appreciate it. Going to merge it

@jonniebigodes jonniebigodes merged commit d43490a into next Apr 13, 2023
@jonniebigodes jonniebigodes deleted the chore_update_links_composition_sidebar branch April 13, 2023 14:46
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 15, 2023
shilman pushed a commit that referenced this pull request Apr 15, 2023
…tion_sidebar

Chore: (UI) Updates sidebar composition links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Composition - info dropdown in dark theme looks incorrect, link to docs is wrong
3 participants