Create channel url on client from window.location #22055
Merged
+19
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just run into the server channel issue after upgrading to SB7.0.4. We are using it behind nginx proxies. Is it possible to opt out of using server channels at all? Thanks! |
ndelangen
reviewed
Apr 20, 2023
| const getProjectAnnotations = () => | ||
| composeConfigs([{{#each previewAnnotations}}require('{{this}}'),{{/each}}]); | ||
|
|
||
| const channel = createPostMessageChannel({ page: 'preview' }); | ||
| addons.setChannel(channel); | ||
|
|
||
| if (SERVER_CHANNEL_URL) { |
There was a problem hiding this comment.
At first I was worried that removing this if-statement might cause it to run more often, but it looks like it was always true already, because getServerChannelUrl always returns a non-empty string already.
ndelangen
approved these changes
Apr 20, 2023
ndelangen
added
the
patch:yes
shilman
added
patch:done
shilman
pushed a commit
that referenced
this pull request
May 23, 2023
Create channel url on client from window.location
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20068
What I did
Create channels URL dynamically on the client by using the window location object. I got rid of
SERVER_CHANNEL_URL. I don't see a case where it is really needed anymore, but not sure about that.How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["bug"]