Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2209 knobs refactor accidentally removed select #2210

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

danielduan
Copy link
Member

Issue:

select got accidentally removed somewhere in the refactor #2209

What I did

added it back

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@danielduan danielduan added this to the v3.3.0 milestone Nov 2, 2017
@Hypnosphi
Copy link
Member

Do we need it in app/vue as well?

@danielduan
Copy link
Member Author

danielduan commented Nov 2, 2017

nah I think all other instances inside the knob folder looks fine to me. just this one i believe.

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #2210 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #2210   +/-   ##
============================================
  Coverage        21.98%   21.98%           
============================================
  Files              338      338           
  Lines             6700     6700           
  Branches           892      884    -8     
============================================
  Hits              1473     1473           
- Misses            4549     4570   +21     
+ Partials           678      657   -21
Impacted Files Coverage Δ
addons/knobs/src/index.js 0% <ø> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
addons/info/src/components/types/InstanceOf.js 16.66% <0%> (ø) ⬆️
addons/info/src/components/types/proptypes.js 16.66% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/components/src/table/cell.js 0% <0%> (ø) ⬆️
lib/components/src/highlight_button.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 26.74% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e4d23...a5f3c38. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants