Update code example of framework standalone build #22102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`build` is now exported from core-server since 7.0.0-beta.25. https://github.com/storybookjs/storybook/blob/main/CHANGELOG.md#bug-fixes-52 https://github.com/storybookjs/storybook/blob/main/code/lib/core-server/src/index.ts#L9 This PR fixes the code example to `require` it correctly. Also, the example of old usage wasn't correct either, so I updated that too.
jonniebigodes
added
the
patch:yes
|
@joeycozza thanks for taking the time to put together this small but rather important pull request and update our Migration documentation. Appreciate it 🙏 ! I've checked and all is good on my end. Going to merge this one once the checklist clears. Hope you have a great day. Stay safe |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Apr 24, 2023
Update code example of framework standalone build
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildis now exported from core-server since 7.0.0-beta.25.https://github.com/storybookjs/storybook/blob/main/CHANGELOG.md#bug-fixes-54
https://github.com/storybookjs/storybook/blob/main/code/lib/core-server/src/index.ts#L9
This PR fixes the code example to
requireit correctly. Also, the example of old usage wasn't correct either, so I updated that too.Closes #
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]