Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Docs): update code snippet link #22117

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix(Docs): update code snippet link #22117

merged 1 commit into from
Apr 17, 2023

Conversation

Yilun-Sun
Copy link
Contributor

@Yilun-Sun Yilun-Sun commented Apr 17, 2023 •
edited
Loading

What I did

  • fix code snippet link
    image

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@Yilun-Sun Yilun-Sun changed the title Documentation: update code snippet link fix(Docs): update code snippet link Apr 17, 2023
jonniebigodes
jonniebigodes approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yilun-Sun thanks for taking the time to put together this pull request and helping us out with our documentation by catching this small but rather important typo in our examples. We appreciate it. I've checked, and is all good on my end. I'll merge it as soon as the checklist clears.

Hope you have a great week.

Stay safe

@jonniebigodes jonniebigodes self-assigned this Apr 17, 2023
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 17, 2023
@jonniebigodes jonniebigodes merged commit a3c5b64 into storybookjs:next Apr 17, 2023
@Yilun-Sun Yilun-Sun deleted the patch-1 branch April 18, 2023 00:50
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 18, 2023
shilman pushed a commit that referenced this pull request Apr 18, 2023
@jonniebigodes @shilman
Merge pull request #22117 from Yilun-Sun/patch-1
8035c43 
fix(Docs): update code snippet link
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonniebigodes jonniebigodes jonniebigodes approved these changes

Assignees

@jonniebigodes jonniebigodes

Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yilun-Sun @jonniebigodes @shilman