Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to StoryShots #22130

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

joriswitteman
Copy link
Contributor

@joriswitteman joriswitteman commented Apr 17, 2023

I must wonder how well StoryShots is still maintained/supported if their links are broken in the main docs.

What I did

Fixed the links to the StoryShots READMEs

How to test

Visit the Visual Testing page and click the links for StoryShots

@joeycozza
Copy link
Contributor

Storybook made a big change to the structure of the repo putting lots of stuff in into the code directory. Just because they forgot to update a url or missed them doesn't mean the underlying tool isn't supported/maintained.

@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 18, 2023
@jonniebigodes
Copy link
Contributor

@joriswitteman, thanks for taking the time to put together this pull request and update the documentation by catching this small but rather important typo. We appreciate it 🙏 ! To give you a bit of context, I'm sure that the documentation was working correctly in earlier versions, but with the recent migration for Storybook 7.0, that pull request must have been lost in the shuffle.

And @joeycozza, thanks for the response. You're correct, but as I've mentioned, this situation may have happened as I already mentioned.

Going to merge once the checklist clears.

Hope both of you have a great day.

Stay safe

@jonniebigodes jonniebigodes merged commit ce88fd1 into storybookjs:next Apr 18, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants