Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS version of Button story with hooks snippet #22149

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

kylegach
Copy link
Contributor

What I did

See title

How to test

Follow the steps in the contributing instructions for this branch, add-ts-react-hooks-snippet

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kylegach kylegach added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 18, 2023
@kylegach kylegach self-assigned this Apr 18, 2023
@kylegach kylegach requested a review from jonniebigodes April 18, 2023 17:47
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylegach, thanks for this pull request and for adding the example to the documentation. I just ran pretty-docs to prevent issues, and asides from that all is good on my end.

@jonniebigodes
Copy link
Contributor

Going to go ahead and merge this one as it's documentation-only, and the failure in the Unit tests is completely unrelated to this body of work

@jonniebigodes jonniebigodes merged commit 8d667f6 into next Apr 18, 2023
@jonniebigodes jonniebigodes deleted the add-ts-react-hooks-snippet branch April 18, 2023 18:46
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman pushed a commit that referenced this pull request Apr 24, 2023
Add TS version of Button story with hooks snippet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants