-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add benchmark task #22161
Build: Add benchmark task #22161
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
This reverts commit ea192ec.
… into shilman/bench-task
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
@shilman It's green! Let's discuss next step.
|
😢 |
@ndelangen there are still a bunch of values that are not getting filled in, but otherwise it is starting to look OK |
This is absolutely awesome! 🎉 |
Build: Add benchmark task (cherry picked from commit 162ba43)
Closes #21511
What I did
I replaced our script for bench-marking storybook.
The
@storybook/addon-bench
is now deprecated, no longer used.I've archived that repository.
I'm now tracking a bunch of more meaningful data about storybook:
storybook/scripts/bench/types.ts
Lines 3 to 61 in ac6984f
This should make it easier for us to detect regressions in performance and size, and also make it easier to verify if what we're doing has impact we think it should have.
How to test
When running sandboxes, a
bench.json
file should be created when tasks run.Each task is responsible for tracking it's own metrics. This is to ensure we can expand this system over time.
I did make 1
bench
task that collects data via playwright.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]