-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glob to v10.0.0 #22171
Update glob to v10.0.0 #22171
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
|
@NotWoods I'll update this branch with the base-branch. Can you investigate the unit-test failures? |
Which check does the unit test failures appear under? |
ah never mind, might have been inconsistent. I'll get this updated, and merged. |
This change broke some things... |
Having The last safe version of A solution could be to switch to EDIT: The author of Not sure that's a realistic solution. |
@JReinhold Didn't your PR address this problem? |
I agree, with storybook 7.3 and 7.4 using yarn i have the same problems ... eslint and webpack scripts are broken |
@zoontek @koni1234 WDYT about using yarn resolutions to pin the version to 10.1.0? I created a PR to try to pin it in SB but @tmeasday mentioned that we have indirect dependencies on it that we can't control, so I closed it. #24002 @zoontek I'd be up for a |
Replacing with |
@yannbf is it possible to catch this error & tell users to pin their dependencies? if so, can you squeeze this into your error handling project? |
FWIW, I took a stab at replacing globby with fdir a while back, for compatibility and performance reasons. It looks like fdir has been improved further since then, and I plan to take another shot at it, though it sounds like that's insufficient due to transitive deps. |
yes, in order to temporary solve this issue I added these dependencies resolutions in the package.json "resolutions": { |
@koni1234 you only need to pin |
What I did
Updated the
glob
library to v10, which includes a promise-based API and a min version of Node 16. Also removed the no longer needed glob-promise library.How to test
This updates the logic for listing stories in a vite project. To test:
yarn task --task sandbox --start-from auto --template react-vite/default-ts
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]