Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Addon panel does not update after disabling/enabling an addon #22258

Merged
merged 3 commits into from
May 1, 2023

Conversation

gitstart
Copy link
Contributor

Issue: #22158

What I did

  • Update useList in tabs.hooks.tsx to show new added tabs

How to test

  • Start a sandbox template: yarn task --task dev --template react-vite/default-ts
  • Add actions: { disable: true } and see it update correctly
  • Change to actions: { disable: false } or remove the line altogether, and see that the panel get updated

Demo

Screen.Recording.2023-04-21.at.14.26.54.mov

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: BikashSah999 <51731962+BikashSah999@users.noreply.github.com>
Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
@gitstart gitstart marked this pull request as ready for review April 26, 2023 08:17
@yannbf yannbf requested a review from valentinpalkovic April 26, 2023 08:42
@yannbf
Copy link
Member

yannbf commented Apr 26, 2023

Hey there! thanks a lot for your contribution <3
@valentinpalkovic would you mind taking a look?

@yannbf yannbf added bug ui patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 1, 2023
@valentinpalkovic valentinpalkovic merged commit db0eee7 into storybookjs:next May 1, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman pushed a commit that referenced this pull request May 3, 2023
fix : Addon panel does not update after disabling/enabling an addon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants