Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove unused imports in MDX documentation #22303

Merged

Conversation

sitogi
Copy link
Contributor

@sitogi sitogi commented Apr 28, 2023

What I did

I removed the unused import Story from a code snippet in the MDX documentation.

How to test

  1. Refer to MDX Documentation and create Checkbox.mdx .
  2. Please confirm that the imported Story is unused and can be safely removed.

Checklist

Skipping because it is a documentation-only fix.

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@jonniebigodes jonniebigodes self-assigned this Apr 29, 2023
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 29, 2023
@sitogi sitogi force-pushed the remove-unused-import-in-mdx-doc branch from 1f5d39b to 0a0394a Compare April 29, 2023 22:48
@jonniebigodes
Copy link
Contributor

@sitogi, thanks for taking the time to put together this pull request. Appreciate it 🙏 ! I've checked and we're good to go, this was a nice find. Once the checklist clears, I'll gladly merge it.

Hope you have a great day.

Stay safe

@jonniebigodes jonniebigodes merged commit e397869 into storybookjs:next May 3, 2023
@sitogi sitogi deleted the remove-unused-import-in-mdx-doc branch May 3, 2023 21:54
@sitogi
Copy link
Contributor Author

sitogi commented May 3, 2023

Thank you for merging!

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 5, 2023
shilman pushed a commit that referenced this pull request May 5, 2023
Docs: Remove unused imports in MDX documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants