Maintenance: Fix css inconsistency in Button and Icon components #22497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
approved these changes
May 10, 2023
yannbf
added
the
patch:yes
|
I hope you're ok with this change @MichaelArestad ! |
|
Can you elaborate on how this was causing flake? |
MichaelArestad
approved these changes
May 10, 2023
shilman
added
components
patch:done
shilman
pushed a commit
that referenced
this pull request
May 12, 2023
Maintenance: Fix css inconsistency in Button and Icon components
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
This is an attempt to fix css inconsistencies which keep causing flakiness in Chromatic
How to test
Chromatic should stop being flaky
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]