CLI: Fix storybook upgrade precheckfailure object #22517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
bug
cli
patch:yes
yannbf
force-pushed
the
fix/upgrade-precheck-failure
branch
from
ed519e9 to
b436f4c
Compare
valentinpalkovic
approved these changes
May 12, 2023
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 12, 2023
CLI: Fix storybook upgrade precheckfailure object
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
This PR fixes two distinct issues, one regarding destructuring a property that was supposed to exist but didn't, the other one is about precheck failures that we supposedly sent to telemetry but actually didn't!
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]