feat(repo): upgrade to latest version of Nx #22574

mandarini · 2023-05-16T12:53:22Z

NOTE: Maybe use this updated PR instead: #22694

What I did

Updated repo to latest Nx.

How to test

I upgraded and then ran yarn task and compiled all projects, all projects compiled successfully.

Note:

We can remove migrations.json, I left it there for now, for you to see what scripts it ran! :)

Checklist

Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
Make sure to add/update documentation regarding your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Maintainers

If this PR should be tested against many or all sandboxes,
make sure to add the ci:merged or ci:daily GH label to it.
Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

socket-security · 2023-05-16T13:00:38Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore @nx/devkit@16.1.4
@SocketSecurity ignore @nx/devkit@16.2.1
@SocketSecurity ignore @nx/workspace@16.1.4
@SocketSecurity ignore @nx/workspace@16.2.1
@SocketSecurity ignore nx-cloud@16.0.5

⚠️ Shell access

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Package	Module	Location	Source
@nx/devkit@16.1.4 (added)	child_process	src/tasks/install-packages-task.js	`code/package.json` via @nx/workspace@16.1.4
@nx/devkit@16.1.4 (added)	child_process	src/utils/package-json.js	`code/package.json` via @nx/workspace@16.1.4
@nx/devkit@16.2.1 (added)	child_process	src/tasks/install-packages-task.js	`scripts/package.json` via @nx/workspace@16.2.1
@nx/devkit@16.2.1 (added)	child_process	src/utils/package-json.js	`scripts/package.json` via @nx/workspace@16.2.1
@nx/workspace@16.1.4 (added)	child_process	src/generators/new/generate-preset.js	`code/package.json`
@nx/workspace@16.1.4 (added)	child_process	src/generators/utils/get-npm-package-version.js	`code/package.json`
@nx/workspace@16.1.4 (added)	child_process	src/utilities/default-base.js	`code/package.json`
@nx/workspace@16.2.1 (added)	child_process	src/generators/new/generate-preset.js	`scripts/package.json`
@nx/workspace@16.2.1 (added)	child_process	src/generators/utils/get-npm-package-version.js	`scripts/package.json`
@nx/workspace@16.2.1 (added)	child_process	src/utilities/default-base.js	`scripts/package.json`
nx-cloud@16.0.5 (added)	child_process	lib/core/commands/record-output.js	`code/package.json`, `scripts/package.json`
nx-cloud@16.0.5 (added)	child_process	lib/utilities/environment.js	`code/package.json`, `scripts/package.json`

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Shell access	⚠️ 12 issues
Uses eval	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
GitHub dependency	✅ 0 issues
New author	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package	Capability Access	`+/-` Transitive Count	Publisher
nx-cloud@16.0.5	filesystem, shell, environment	`+4`	altan-nrwl
@nx/workspace@16.1.4	filesystem, shell, environment	`+14`	nrwl-jason
@nx/workspace@16.2.1	filesystem, shell, environment	`+14`	nrwl-jason
nx@16.1.4	environment	`+10`	nrwl-jason
nx@16.2.1	environment	`+10`	nrwl-jason

🚮 Removed packages: @nrwl/nx-cloud@15.3.5, @nrwl/workspace@15.9.4

chakAs3 · 2023-05-16T17:34:39Z

hi @mandarini thanks for your work.
I'm testing it now, indeed the build passes, However, i'm trying to run some scripts, to create and run the sandboxes.


⚙️ Initializing Storybook
> node /Users/chakir/devs/storybook/code/lib/cli/bin/index.js init --yes

for react yarn start it is stuck here never finished.
for vue3-vite it works very fast

mandarini · 2023-05-17T14:49:19Z

@chakAs3 can you tell me what command you are running exactly, and in which directory?

chakAs3 · 2023-05-17T16:35:28Z

@chakAs3 can you tell me what command you are running exactly, and in which directory?
root directory

yarn task --task dev --template react-vite/default-ts --start-from=install

it is stuck in prompts asking some plugin install, the promise is not returned

if i bypass the prompts it passes .

mandarini · 2023-05-18T08:52:33Z

@chakAs3 yes ok I just verified. Weird, I wonder what it can be. I'm looking into it. In any case, I updated the scripts directory too

mandarini · 2023-05-18T08:59:01Z

@chakAs3 same thing happens to me in latest next, in the existing version of Nx, before migrating. So I guess that's not an issue with the migration... And it does not look like an issue with Nx either, I believe. :( It just hangs there forever.

chakAs3 · 2023-05-18T14:19:37Z

@chakAs3 same thing happens to me in latest next, in the existing version of Nx, before migrating. So I guess that's not an issue with the migration... And it does not look like an issue with Nx either, I believe. :( It just hangs there forever.

You are right it looked not related to NX anyway, i have even upgraded the'prompts' package, even replace with @clack/prompts but it is same just stuck there

mandarini · 2023-05-18T15:04:23Z

I see! Let me know what you think about updating Nx, in any case! :)

shilman · 2023-05-19T02:52:50Z

@chakAs3 This was a CLI change that was introduced last week. I believe @yannbf and @ndelangen will have a fix today

chakAs3 · 2023-05-20T22:16:36Z

@chakAs3 This was a CLI change that was introduced last week. I believe @yannbf and @ndelangen will have a fix today

yes it was the prompts, it was fixed with a workaround to unblock the contributors.

chakAs3

I revert back to nx@16.2.1 as the beta creating some issue for with type checking

This reverts commit e28ba93.

chakAs3 · 2023-05-22T13:46:41Z

Hi @mandarini i hope you are having a good week start.

Unfortunately i could not merge your PR, I'm getting plenty of type checking errors, so CI tests won't pass
to test run yarn ci-tests or yarn task --task check --no-link

mandarini · 2023-05-23T08:32:05Z

Hi @chakAs3 ! I will rebase my PR, squash the commits and push again if that's ok with you. I re-applied the latest upgrade, just to see the effects after rebasing with latest next. You can ping me on slack/discord if you want to briefly pair on this today. The tests are passing on my end, but I understand that "works on my machine" does not say much, hehe! :)

mandarini · 2023-05-23T09:20:36Z

@chakAs3 @shilman I created a new PR from scratch, and it seems to work for me, but let's test again! #22694

ndelangen · 2023-05-23T11:52:08Z

I suppose the new PR replaces this one?

feat(repo): upgrade to latest version of Nx

e28ba93

mandarini added the dependencies label May 16, 2023

mandarini mentioned this pull request May 16, 2023

upgrade nx to add support for darwin-x64 #22449

Merged

5 tasks

mandarini self-assigned this May 16, 2023

mandarini marked this pull request as ready for review May 16, 2023 12:55

chakAs3 self-assigned this May 16, 2023

chakAs3 requested review from chakAs3 and IanVS May 16, 2023 17:30

feat(repo): upgrade to latest version of Nx

7e87476

mandarini force-pushed the feat/migrate-nx branch from 0b07a4a to 7e87476 Compare May 18, 2023 09:01

chakAs3 added 2 commits May 19, 2023 06:25

Merge branch 'feat/migrate-nx' into feat/migrate-nx

730510b

Merge branch 'next' into feat/migrate-nx

d34ab23

Merge branch 'next' into feat/migrate-nx

782a477

remove nx migrartion file

24a0f4d

chakAs3 approved these changes May 21, 2023

View reviewed changes

Revert "feat(repo): upgrade to latest version of Nx"

85d0b65

This reverts commit e28ba93.

chakAs3 self-requested a review May 22, 2023 13:41

ndelangen closed this May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(repo): upgrade to latest version of Nx #22574

feat(repo): upgrade to latest version of Nx #22574

mandarini commented May 16, 2023 •

edited

Loading

socket-security bot commented May 16, 2023 •

edited

Loading

chakAs3 commented May 16, 2023 •

edited

Loading

mandarini commented May 17, 2023

chakAs3 commented May 17, 2023 •

edited by IanVS

Loading

mandarini commented May 18, 2023 •

edited

Loading

mandarini commented May 18, 2023 •

edited

Loading

chakAs3 commented May 18, 2023

mandarini commented May 18, 2023

shilman commented May 19, 2023

chakAs3 commented May 20, 2023

chakAs3 left a comment

chakAs3 commented May 22, 2023 •

edited

Loading

mandarini commented May 23, 2023

mandarini commented May 23, 2023

ndelangen commented May 23, 2023

feat(repo): upgrade to latest version of Nx #22574

feat(repo): upgrade to latest version of Nx #22574

Conversation

mandarini commented May 16, 2023 • edited Loading

What I did

How to test

Note:

Checklist

Maintainers

socket-security bot commented May 16, 2023 • edited Loading

chakAs3 commented May 16, 2023 • edited Loading

mandarini commented May 17, 2023

chakAs3 commented May 17, 2023 • edited by IanVS Loading

mandarini commented May 18, 2023 • edited Loading

mandarini commented May 18, 2023 • edited Loading

chakAs3 commented May 18, 2023

mandarini commented May 18, 2023

shilman commented May 19, 2023

chakAs3 commented May 20, 2023

chakAs3 left a comment

Choose a reason for hiding this comment

chakAs3 commented May 22, 2023 • edited Loading

mandarini commented May 23, 2023

mandarini commented May 23, 2023

ndelangen commented May 23, 2023

mandarini commented May 16, 2023 •

edited

Loading

socket-security bot commented May 16, 2023 •

edited

Loading

chakAs3 commented May 16, 2023 •

edited

Loading

chakAs3 commented May 17, 2023 •

edited by IanVS

Loading

mandarini commented May 18, 2023 •

edited

Loading

mandarini commented May 18, 2023 •

edited

Loading

chakAs3 commented May 22, 2023 •

edited

Loading