CLI: Skip prompting for eslint plugin with --yes flag #22651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
bug
cli
patch:yes
chakAs3
reviewed
May 20, 2023
| @@ -358,8 +364,7 @@ export async function baseGenerator( | |||
| ); | |||
|
|
|||
| if (hasEslint && !isStorybookPluginInstalled) { | |||
| const shouldInstallESLintPlugin = await suggestESLintPlugin(); | |||
| if (shouldInstallESLintPlugin) { | |||
| if (skipPrompts || (await suggestESLintPlugin())) { | |||
There was a problem hiding this comment.
that is almost what i did. to bpass the prompts, however we agreed, we still need to fix this issue.
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
CLI: Skip prompting for eslint plugin with --yes flag
Merged
5 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
The sandbox commands were hanging locally because the ESlint check would get prompted but the logs were hidden. Cryptic!
This PR fixes that issue (which would also be applicable for users that run
storybook init --yesHow to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]