Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read dev-dep react-scripts too when called on CRA projects #22886

Closed
wants to merge 1 commit into from

Conversation

Sidnioulz
Copy link
Member

Closes #22794

What I did

Added support for readinv devDependencies too

How to test

  1. Create a new CRA project: npx create-react-app my-app && cd my-app
  2. Init storybook node /path-to-sb/code/lib/cli/bin/index.js init
  3. Notice nothing crashes

Checklist

NOTE: I am unsure if this requires a dedicated test or not.

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["bug"]

@Sidnioulz Sidnioulz requested a review from a team as a code owner June 2, 2023 14:55
@valentinpalkovic valentinpalkovic self-requested a review June 2, 2023 16:41
@valentinpalkovic valentinpalkovic self-assigned this Jun 5, 2023
@ndelangen
Copy link
Member

This PR will likely get superseded by #22642 don't you think @valentinpalkovic

@valentinpalkovic
Copy link
Contributor

Very likely. Nevertheless, I would like to keep this open to see, whether the issue gets resolved after my PR got merged.

@valentinpalkovic
Copy link
Contributor

Closing, since it is fixed here: https://github.com/storybookjs/storybook/pull/22642/files#diff-9305f6962a92f45ede95181bc8aeaeb5e0bf20a3d66f2aadeb7713d2391aac16L28

Nevertheless, @Sidnioulz Thank you for your effort in putting this PR together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Storybook 7.0+ doesn't support react-scripts@<5.0.0.
3 participants