Next.js: Fix useParams support
#22946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
next/navigation#useParams returns null when using @storybook/nextjsuseParams support
shilman
added
the
patch:yes
shilman
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Looks great! Waiting for our NextJS expert @valentinpalkovic to take a look before merging. He'll be back from vacation next week.
valentinpalkovic
added
the
ci:daily
|
@gitstart-storybook Thank you so much for your PR! The changes look amazing. Could you do me a favor and adjust the documentation after https://github.com/storybookjs/storybook/tree/next/code/frameworks/nextjs#useselectedlayoutsegment-and-useselectedlayoutsegments-hook as well, to describe how to set the data properly? |
Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
valentinpalkovic
approved these changes
Jun 19, 2023
This was referenced Jun 19, 2023
Merged
shilman
removed
the
patch:yes
shilman
added
the
patch:yes
This was referenced Jul 4, 2023
Merged
Merged
valentinpalkovic
changed the title
useParams supportuseParams support
valentinpalkovic
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #22077
What I did
GlobalLayoutRouterContextintoAppRouterProviderto passuseParamsvalidation in nextjsuseParamsHow to test
useParamsusage doesn't throw any errors.useParamsmocking valueRef
GitStart Ticket