Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add details for defaultOrientation #23104

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

smeagol74
Copy link
Contributor

According to #21962 new feature added, but were not documented yet.

Closes #

What I did

Just added some new documentation to the page.

How to test

Open the https://storybook.js.org/docs/react/essentials/viewport documentation page and see it describes new option.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["documentation"]

According to storybookjs#21962 new feature added, but were not documented yet.
@jonniebigodes jonniebigodes self-assigned this Jun 16, 2023
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 16, 2023
@kylegach kylegach self-assigned this Jun 16, 2023
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, @smeagol74. And congratulations on your first contribution! 🥳 Thanks!

@kylegach kylegach changed the title Update viewport.md Docs: Update viewport.md Jun 16, 2023
@kylegach kylegach changed the title Docs: Update viewport.md Docs: Add details for defaultViewport Jun 16, 2023
@kylegach kylegach changed the title Docs: Add details for defaultViewport Docs: Add details for defaultOrientation Jun 16, 2023
@kylegach kylegach merged commit 4811425 into storybookjs:next Jun 16, 2023
JReinhold pushed a commit that referenced this pull request Jun 16, 2023
Docs: Add details for `defaultOrientation`
(cherry picked from commit 4811425)
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
9 tasks
JReinhold pushed a commit that referenced this pull request Jun 17, 2023
Docs: Add details for `defaultOrientation`
(cherry picked from commit 4811425)
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants