-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update button-story.ts.mdx #23158
Update button-story.ts.mdx #23158
Conversation
The type on Primary was not working so I changed it.
@jared-christensen, thanks for taking the time to put together this pull request and help us improve the documentation. We appreciate it 🙏 ! I've checked, and all is good on my end. And will merge after the checklist clears. One thing that I wanted to ask you, would you be interested in vetting and updating the Let me know, and we'll go from there. Looking forward to hearing from you. Have a fantastic day. Stay safe |
Thanks for thinking of me for this! My main focus is on Stencil right now, so I might not be the best person to comb through all the HTML snippets in the docs. That being said, I'm all about improving things where I can. If I spot something off, I'll definitely whip up a PR. In fact, I've already got my eye on a spot that mentions Stencil in the docs that could use some love. Appreciate you reaching out, and looking forward to pitching in where I can. Cheers! |
No need to thank whatsoever. And appreciate the follow-up and interest in helping us out. Looking forward to seeing the pull request up and if you're ok with it, tag me in it, and I'll be more than glad to review it. |
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
Update button-story.ts.mdx (cherry picked from commit 6c0a764)
The type on Primary was not working so I changed it.