-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Exit when user does not select a storybook project type #23201
Changes from 2 commits
e89a3ad
c85081b
9e47ab3
c780001
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,8 +63,8 @@ export const SUPPORTED_RENDERERS: SupportedRenderers[] = [ | |
export enum ProjectType { | ||
UNDETECTED = 'UNDETECTED', | ||
UNSUPPORTED = 'UNSUPPORTED', | ||
REACT_SCRIPTS = 'REACT_SCRIPTS', | ||
REACT = 'REACT', | ||
REACT_SCRIPTS = 'REACT_SCRIPTS', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the story here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have a big error count regarding "Storybook does not support react-scripts < 5.0.0" and this error can also be thrown when you choose react-scripts from the list of projects to install, but you don't have react-scripts installed. I suspect what is influencing this count so much is that people just press enter when they get a list of options, and react-scripts is the first in the list. By changing the order, people will get |
||
REACT_NATIVE = 'REACT_NATIVE', | ||
REACT_PROJECT = 'REACT_PROJECT', | ||
WEBPACK_REACT = 'WEBPACK_REACT', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman reminder to check this later, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this. I think it's not great for our telemetry, but hopefully it's a small corner case.