Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import to webpack extends example #2330

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Add import to webpack extends example #2330

merged 1 commit into from
Nov 16, 2017

Conversation

jjwon0
Copy link
Contributor

@jjwon0 jjwon0 commented Nov 16, 2017

Issue:

What I did

Update code sample in docs

How to test

Build website

Is this testable with jest or storyshots?

Don't think so?

Does this need a new example in the kitchen sink apps?

Don't think so?

Does this need an update to the documentation?

N/A

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #2330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2330   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      724      729    +5     
=======================================
  Hits         1305     1305           
+ Misses       4310     4296   -14     
- Partials      541      555   +14
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/configs/handle_routing.js 24.73% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.88% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e814a44...5f1552b. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjwon0!

@Hypnosphi Hypnosphi merged commit ead3002 into storybookjs:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants