-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: refactor Canvas component so we can improve types for PREVIEW addons and TAB addons #23311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
add more jsdoc
Typescript: Add more JSdocs & improve code-quality
Jul 4, 2023
tmeasday
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm apart from one query
…use their interface is actually quite different
…t. I verified they actually work, as well as custom tabs
ndelangen
changed the title
Typescript: Add more JSdocs & improve code-quality
UI: refactor Canvas component so we can improve types for PREVIEW addons and TAB addons
Jul 5, 2023
…s/storybook into norbert/addon-types-follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Addon_TypesEnum.PREVIEW
type fromAddon_BaseTypes
, because a PREVIEW-type addon actually has a different interface.How to test
.storybook/manager.ts
to.storybook/manager.tsx
inside theui
directory/custom
to the path, which makes the custom Tab content render (on top of the normal canvas)docs
orstory
..If a TAB navigates to something else, they'll have to handle showing something in another way. (that's what full viewport addons
experimental_PAGE
type addons will be able to handle.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]