DangerJS: Require either 'patch:no', 'patch:yes' or 'patch:done' label #23358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the title
valentinpalkovic
added
build
valentinpalkovic
force-pushed
the
valentin/require-patch-no-patch-label
branch
from
a8d8c33
to
8663fe9
Compare
valentinpalkovic
changed the title
valentinpalkovic
force-pushed
the
valentin/require-patch-no-patch-label
branch
from
8663fe9
to
efffec8
Compare
|
Shouldn't this be patched? |
valentinpalkovic
added
patch:yes
JReinhold
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
@valentinpalkovic I've added the changes to the release tooling that I think are necessary.
I've also changed the danger logic slightly, to allow "patch:done" with "patch:yes" or "patch:no". Essentially we don't remove "patch:yes" when adding "patch:done", I just think we want to ensure that there is always one of either "patch:yes" and "patch:no", ignoring "patch:done".
9 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jul 11, 2023
…patch-label DangerJS: Require either 'patch:no', 'patch:yes' or 'patch:done' label (cherry picked from commit e1350e2)
This was referenced Jul 11, 2023
10 tasks
github-actions
bot
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Often the "patch" label is forgotten. This PR changes Danger.js to always enforce setting either a "patch:yes", "patch:no" or "patch:done" label.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]