Controls: Fix grouped Radio controls to have the same name #23374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add any test for now, I don't think you have component test ? |
srapilly
changed the title
|
Hi @JReinhold, should I do something so that you can approve/merge this PR ? thanks |
srapilly
force-pushed
the
group-radio-by-name
branch
from
6b3bfe4 to
63a952b
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aea3797. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
13 tasks
|
Thanks for the merge, I had completely forgotten this PR :) |
shilman
changed the title
valentinpalkovic
added
the
needs qa
ghengeveld
removed
the
needs qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
no existing issue
What I did
Each radio control in the same group should have the same name. This fix the keyboard behavior, it was not possible to changes radio with the arrow keys. This will also group them for screen reader users.
How to test
yarn task --task sandbox --start-from auto --template react-vite/default-tsChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]