Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotenv support for storybook in vue and react #2345

Merged
merged 6 commits into from
Nov 22, 2017

Conversation

RWOverdijk
Copy link
Member

Issue:

What I did

Added support for dotenv

How to test

Add to a new CRA app and use the .env files.

Misc

I guess this could be added to the docs but I wouldn't know where. Busy busy so if it's a must I'll look for it this weekend.

@RWOverdijk
Copy link
Member Author

I didn't see any lock files when adding this.

@Hypnosphi
Copy link
Member

Hypnosphi commented Nov 21, 2017

What happens when you run yarn bootstrap --reset --core --docs and then git status ?

@RWOverdijk
Copy link
Member Author

My bad. Pushed.

@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #2345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2345   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files         283      283           
  Lines        6155     6155           
  Branches      713      723   +10     
=======================================
  Hits         1307     1307           
+ Misses       4311     4298   -13     
- Partials      537      550   +13
Impacted Files Coverage Δ
app/react/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21.36% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762e8e3...2462dcc. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 0ed6e1f into storybookjs:master Nov 22, 2017
@RWOverdijk RWOverdijk deleted the patch-1 branch November 22, 2017 10:54
@danielduan
Copy link
Member

is there any way to silence the error when there isn't a .env file?

It's an optional file so I feel like the Failed to load ./.env. is misleading @RWOverdijk

@priley86
Copy link
Member

+1 for not requiring .env and throwing a warning w/o it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants