-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Gracefully shutdown and cleanup execa child processes #23538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execa child processes should be cleanup up as soon as the parent process quits. During initialization the "cancel" event should properly be sent and it should not lead to error events sent.
valentinpalkovic
added
patch:yes
Bugfix & documentation PR that need to be picked to main branch
ci:daily
Run the CI jobs that normally run in the daily job.
labels
Jul 20, 2023
valentinpalkovic
changed the title
Gracefully shutdown and cleanup execa child processes
CLI: Gracefully shutdown and cleanup execa child processes
Jul 20, 2023
valentinpalkovic
requested review from
ndelangen,
JReinhold,
tmeasday and
kasperpeulen
as code owners
July 20, 2023 11:59
I tested this flow in a react-vite sandbox:
The events were as following:
|
yannbf
reviewed
Jul 21, 2023
yannbf
reviewed
Jul 21, 2023
yannbf
approved these changes
Jul 21, 2023
yannbf
approved these changes
Jul 21, 2023
This was referenced Jul 21, 2023
Merged
JReinhold
pushed a commit
that referenced
this pull request
Jul 24, 2023
…ling-and-logging CLI: Gracefully shutdown and cleanup execa child processes (cherry picked from commit 779b4f6)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jul 24, 2023
30 tasks
@mrharispe Could be. Could you open a new issue and provide a reproduction, if possible? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:daily
Run the CI jobs that normally run in the daily job.
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
telemetry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Execa child processes should be cleanup up as soon as the parent process quits. During initialization, the "cancel" event should properly be sent, and it should not lead to error events sent.
Also set the cleanup option to all our
execa
command executions, since I think the child processes shouldn't continue to run if the parent process exits.How to test
STORYBOOK_TELEMETRY_DEBUG=1 <storybook-folder>/code/lib/cli/bin/index.js init --force
in one of the sandboxes.Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]