Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resolve typos in imports on highlight addon docs #23562

Merged
merged 2 commits into from
Jul 24, 2023
Merged

docs: resolve typos in imports on highlight addon docs #23562

merged 2 commits into from
Jul 24, 2023

Conversation

dprcoles
Copy link
Contributor

What I did

Small change to fix a typo that was causing an issue with the rendering of the code snippet that is shown on the Highlight Addon page.

Updated form --> from to resolve syntax highlighting issues.

image

Also updated 2 related snippet files that had the same typo.

How to test

N/A

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

@jonniebigodes jonniebigodes self-assigned this Jul 21, 2023
@jonniebigodes jonniebigodes added documentation patch:no patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal and removed patch:no labels Jul 23, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprcoles, thanks for putting together this pull request and helping us improve the documentation by catching those small but rather important typos. We appreciate it 🙏 !

I've checked, and all is good on my end.

Heads up @yannbf, @valentinpalkovic, I'm aware that the pretty-docs task is failing, but I'll merge this once the checklist clears, as this is a minor documentation change, and I'm going to make some updates to it this week.

@jonniebigodes jonniebigodes merged commit 315833b into storybookjs:next Jul 24, 2023
6 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
27 tasks
@dprcoles dprcoles deleted the highlight-addon-snippet-typos branch July 24, 2023 20:29
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
30 tasks
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants